• Grandwolf319@sh.itjust.worksEnglish
    5·
    24 days ago

    Two wrongs don’t make a right, but sometimes in programming, two bugs can cancel each other out.

    Whoever wrote this is more than capable of using it incorrectly.

    • olympicyes@lemmy.worldEnglish
      1·
      22 days ago

      I’ve asked ChatGPT to create boiler plate code and it will offer these nested functions so you can change the logic in the future. It’s not smart enough to ask why you’re doing something a particular way or suggest a better alternative.

  • Acters@lemmy.worldEnglish
    2·
    24 days ago

    Those are rookie lines of code numbers right there.
    I would have done it without the ==

    internal static bool AreBooleansEqual(bool orig, bool val)
{
    if(orig) 
    {
        if(val)
            return false
        return true
    }
    if(val)
        return true 
    return false
}

    Don’t know why their code returns false when they are equal but I’m not going to dig through old code to refactor to use true instead of false.

    • InFerNo@lemmy.mlEnglish
      0·
      23 days ago

      Put more curly brackets around your if (val) true statement for 4 more lines, put elses in there for more lines even.

      • Acters@lemmy.worldEnglish
        3·
        23 days ago

        I should have created a local variable to store the result variable and return after the if statements. I just couldn’t help to make it look partially nice. My brain just doesn’t think at this high caliber of LOC optimizations.

        New optimized LOC version:

        internal static bool AreBooleansEqual(bool orig, bool val)
{
    bool result;
    if(orig) 
    {
        if(val)
        {
            result = false;
        }
        else
        {
            result = true;
        }
    }
    else
    {
        if(val)
        {
            result = true;
        }
        else
        {
            result = false;
        }
    }
    return result;
}

        My previous LOC: 12
        New LOC version: 27

      • Acters@lemmy.worldEnglish
        0·
        23 days ago

        I was debating on bitwise operations, but decided on super basic if statements which I think the compiler would optimize, happy to see the logical operation form too

  • mlg@lemmy.worldEnglish
    1·
    24 days ago

    “We need to obfuscate our code to prevent reverse engineering”

    The obfuscation in question:

    • Wrench@lemmy.worldEnglish
      3·
      24 days ago

      We affectionately called it “subscurity” on the FE team.

      When our BE apis would not give us any information why something failed, nor would they give us access to their logs. Complete black box of undocumented doodoo, and they would proudly say “security through obscurity” every time we asked why they couldn’t make improvements to usability.