I should have created a local variable to store the result variable and return after the if statements. I just couldn’t help to make it look partially nice. My brain just doesn’t think at this high caliber of LOC optimizations.
New optimized LOC version:
internalstaticboolAreBooleansEqual(bool orig, bool val)
{
bool result;
if(orig)
{
if(val)
{
result = false;
}
else
{
result = true;
}
}
else
{
if(val)
{
result = true;
}
else
{
result = false;
}
}
return result;
}
I was debating on bitwise operations, but decided on super basic if statements which I think the compiler would optimize, happy to see the logical operation form too
Those are rookie lines of code numbers right there.
I would have done it without the
==internal static bool AreBooleansEqual(bool orig, bool val) { if(orig) { if(val) return false return true } if(val) return true return false }Don’t know why their code returns false when they are equal but I’m not going to dig through old code to refactor to use true instead of false.
Put more curly brackets around your if (val) true statement for 4 more lines, put elses in there for more lines even.
I should have created a local variable to store the result variable and return after the if statements. I just couldn’t help to make it look partially nice. My brain just doesn’t think at this high caliber of LOC optimizations.
New optimized LOC version:
internal static bool AreBooleansEqual(bool orig, bool val) { bool result; if(orig) { if(val) { result = false; } else { result = true; } } else { if(val) { result = true; } else { result = false; } } return result; }My previous LOC: 12
New LOC version: 27
you can also use XOR operation
return (X || Y) && !(X && Y)I was debating on bitwise operations, but decided on super basic if statements which I think the compiler would optimize, happy to see the logical operation form too